#20943: Update a missing important speed improvement for subword complexes
-------------------------------------+-------------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: combinatorics | Resolution:
Keywords: reflection group, | Merged in:
coxeter group, subword complex, |
days80 |
Authors: Christian Stump | Reviewers:
Report Upstream: N/A | Work issues:
Branch: u/stumpc5/20943 | Commit:
| aaf771ed669652a1b09d69b5e7c539afa950120a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by chapoton):
* commit: => aaf771ed669652a1b09d69b5e7c539afa950120a
Comment:
Sorry, but I do not understand the logic of your change.
What is this attribute `__number_of_reflections` ? Does it exist only in
the complex reflection group implementation ?
One should also replace the default code for `number_of_reflections` by
the faster
{{{
from sage.rings.all import ZZ
return ZZ.sum(self.degrees() - 1)
}}}
that avoid to use rank.
----
New commits:
||[https://git.sagemath.org/sage.git/commit?id=dad4de4b43bb5405f3a2103ced4fc91cef5e9d65
dad4de4]||{{{fixed the bux}}}||
||[https://git.sagemath.org/sage.git/commit?id=aaf771ed669652a1b09d69b5e7c539afa950120a
aaf771e]||{{{Merge branch 'develop' into u/stumpc5/20943}}}||
--
Ticket URL: <https://trac.sagemath.org/ticket/20943#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
