#20943: Update a missing important speed improvement for subword complexes
-------------------------------------+-------------------------------------
       Reporter:  stumpc5            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  combinatorics      |   Resolution:
       Keywords:  reflection group,  |    Merged in:
  coxeter group, subword complex,    |
  days80                             |
        Authors:  Christian Stump    |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:  u/stumpc5/20943    |       Commit:
                                     |  35a98d714455b0c2408e0420550997c0f7232dd9
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by stumpc5):

 The timings should still be the old as the change
 {{{
 -            return ZZ.sum(self.degrees()) - self.rank()
 +            return ZZ.sum(deg-1 for deg in self.degrees())
 }}}
 should not make any difference... (just checked, no change there). It
 would be better if we either do a speed improvement of the {{{degrees}}}
 method for {{{WeylGroup}}} and {{{CoxeterGroup}}}, or make
 {{{number_of_reflections}}} there use the length of the longest element
 there instead.

--
Ticket URL: <https://trac.sagemath.org/ticket/20943#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to