#20943: Update a missing important speed improvement for subword complexes
-------------------------------------+-------------------------------------
       Reporter:  stumpc5            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  combinatorics      |   Resolution:
       Keywords:  reflection group,  |    Merged in:
  coxeter group, subword complex,    |
  days80                             |
        Authors:  Christian Stump    |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:  u/stumpc5/20943    |       Commit:
                                     |  aaf771ed669652a1b09d69b5e7c539afa950120a
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by stumpc5):

 Okay, I guess you are right. I should and will do it properly:

 1. make the method {{{ReflectionGroup.number_of_reflections}}} use the
 attribute {{{ReflectionGroup._number_of_reflections}}} instead of
 recomputing it,

 2. make this flip code use the method instead of the attribute for
 {{{ReflectionGroup}}} and also use this attribute for {{{WeylGroup}}} and
 {{{CoxeterGroup}}}, and finally

 3. make {{{WeylGroup}}} and {{{CoxeterGroup}}} compute the number of
 reflections in the fastest possible way.

--
Ticket URL: <https://trac.sagemath.org/ticket/20943#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to