#20973: Cartan type Aoo
-------------------------------------+-------------------------------------
Reporter: andrew.mathas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: combinatorics | Resolution:
Keywords: Cartan type, A | Merged in:
infinity |
Authors: Andrew Mathas | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/andrew.mathas/cartan_type_aoo | 9778f9738c6bf83c66f51ff22ba722e75e96d6ba
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Hi Andrew,
Overall, this looks good! It's a bit frustrating to have to write so many
methods that are very similar to existing ones, but I did not quite see a
good way to factor stuff out either.
One thing that could be done is to add a class `CartanType_standard` in
cartan_type.py (and inherit from it in the `CartanType_standard_*`
classes. At least, the inheritance from `UniqueRep` and `SageObject` would
be written out only once.
Plugin failures:
- startup: I guess we can ignore that one
- trac: in cartan_type.py, the second quote in `trac:`20973'` should be a
backquote
Some comments and suggestions:
The method description in the docstrings is not rather inconsistent. I can
see the origin: the rest of the root system code that you took inspiration
from is not very consistent either (mostly by my fault :-)). Still it
would be good to make it more uniform.
{{{
r"""
Return ... .
This implements :meth:`` by returning True.
EXAMPLES::
"""
}}}
I would move most of the doctests from
`type_A_infinity.CartanType.__init__` in the class docstring, as this is
useful documentation. Maybe with a bit of text interspersed explaining
what this type is about (if this feels natural to you).
While you are at it, it should be easy to implement the `index_set`
method.
Cheers,
Nicolas
--
Ticket URL: <https://trac.sagemath.org/ticket/20973#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
