#20973: Cartan type Aoo
-------------------------------------+-------------------------------------
       Reporter:  andrew.mathas      |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  combinatorics      |   Resolution:
       Keywords:  Cartan type, A     |    Merged in:
  infinity                           |
        Authors:  Andrew Mathas      |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/andrew.mathas/cartan_type_aoo    |  3c5370673410e49fc0acbff86d1ba443c72a44a8
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by andrew.mathas):

 I have addressed all of the comments above. Given the ambiguity between
 `oo` and `+oo` I have used `NN` and `ZZ` throughout, although `oo` is a
 synonym for `ZZ`:
 {{{#!sage
     sage: CartanType(['A', NN])
     ['A', NN]
     sage: print(CartanType(['A', NN]).ascii_art())
     O---O---O---O---O---O---O---..
     0   1   2   3
     sage: CartanType(['A', ZZ])
     ['A', ZZ]
     sage: print(CartanType(['A', ZZ]).ascii_art())
     ..---O---O---O---O---O---O---O---..
         -3  -2  -1   0   1   2   3

 }}}
 There is now a `CartanType_standard` class in `cartan_type.py` but, to be
 honest, it does not save a great deal. I played round a little to try and
 rationalise the code but everything seems very tangled because small
 changes in one place cause errors elsewhere. I think that if the code is
 to the cleaned up then it needs to be done by some one who is more
 familiar with it and its' applications in sage.

--
Ticket URL: <https://trac.sagemath.org/ticket/20973#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to