#20973: Cartan type Aoo
-------------------------------------+-------------------------------------
       Reporter:  andrew.mathas      |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  combinatorics      |   Resolution:
       Keywords:  Cartan type, A     |    Merged in:
  infinity                           |
        Authors:  Andrew Mathas      |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/andrew.mathas/cartan_type_aoo    |  9778f9738c6bf83c66f51ff22ba722e75e96d6ba
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by andrew.mathas):

 Replying to [comment:10 nthiery]:

 > One thing that could be done is to add a class `CartanType_standard` in
 cartan_type.py (and inherit from it in the `CartanType_standard_*`
 classes. At least, the inheritance from `UniqueRep` and `SageObject` would
 be written out only once.

 Thanks. I almost did something like this when I when I was putting this
 together. I agree it would be better this way, so I'll try and clean this
 up a little. Along similar lines, there seems to be quite a lot of code
 duplication between `cartan_matrix`, `cartan_type`, `dynkin_diagram`, ...
 I not familiar with the nuances, differences and uses of all of this code
 but it would be good to clean this up down the track.

 Andrew

--
Ticket URL: <https://trac.sagemath.org/ticket/20973#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to