#13215: Skew polynomials
-------------------------------------+-------------------------------------
Reporter: caruso | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.3
Component: algebra | Resolution:
Keywords: skew polynomials | Merged in:
Authors: Xavier Caruso | Reviewers: Burcin Erocal
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/arpitdm/skew_polynomials | e189fec13d005a7fba39a429876c501fe95c05da
Dependencies: #13214, #13303, | Stopgaps:
#13640, #13641, #13642 |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:77 arpitdm]:
> Replying to [comment:75 tscrim]:
> To add to what Johan is asking,
> > - Kill with fire and holy water `is_*` methods. They just trivially
call `isinstance`.
> Which "is_" methods are you referring to? I couldn't really find any
that call isinstance directly apart from the is_SkewPolynomialRing. For
example, ``is_finite`` returns true if the base ring is finite and has
order 1 and false otherwise. And so on. Each have minor conditions that
the user could of course check themselves if need be, but its not always a
one line call and its not always obvious what methods are available to the
user so that they may verify. Should such methods then still be removed?
Sorry, I misspoke slightly. It is the `is_*` functions, which as you say
are things like `is_SkewPolynomialRing`.
> > - You are double importing things in the element class; only keep the
`cimport`'s.
> Could you elaborate with a tiny example or something what you mean by
this?
You should make this change:
{{{#!diff
-from sage.structure.element import Element, AlgebraElement
from sage.structure.element cimport Element, AlgebraElement,
ModuleElement
from sage.structure.parent cimport Parent
-from polynomial_compiled import CompiledPolynomialFunction
from polynomial_compiled cimport CompiledPolynomialFunction
}}}
--
Ticket URL: <https://trac.sagemath.org/ticket/13215#comment:78>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
