#13215: Skew polynomials
-------------------------------------+-------------------------------------
Reporter: caruso | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.3
Component: algebra | Resolution:
Keywords: skew polynomials | Merged in:
Authors: Xavier Caruso | Reviewers: Burcin Erocal
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/arpitdm/skew_polynomials | 22eab5df8c479f46d780c09625d3c7b790b3c816
Dependencies: #13214, #13303, | Stopgaps:
#13640, #13641, #13642 |
-------------------------------------+-------------------------------------
Changes (by dlucas):
* status: needs_review => needs_work
Comment:
Hello,
Good work on docstrings and module documentation, it's much better now.
However, I have some comments:
- documentation does not compile: it seems you have some formatting errors
in bullet lists.
- you used single backquote notation at some places in the documentation
where it should be
double backquotes, e.g. in `SkewPolynomial` class, you wrote `self`
between single backquotes (which triggers LaTeX formatting) instead of
double.
- a few lines below, `default: False`, `False` should be between double
backquotes.
- you kept the import `import sage.misc.latex as latex`. I'm quite sure
you can remove it, but in that case, you'll have to change
`latex.latex(self.base_ring())` to `self.base_ring()._latex_()` (l. 359,
skew_polynomial_ring.py). There's probably some more to change.
Apart from that, it looks good to me.
Patchbot says some doctests fails, but according to which doctests are
failing, I'm quite sure it's not because of this ticket.
Best,
David
--
Ticket URL: <https://trac.sagemath.org/ticket/13215#comment:84>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
