#21088: Base Class for Skew Polynomials over Finite Fields
-------------------------------------+-------------------------------------
Reporter: arpitdm | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-7.3
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: Xavier Caruso, | Reviewers:
Arpit Merchant |
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/arpitdm/finite_fields_skew_polynomial|
1a06b095a569eba51bf2efdc2f86712cfa7b49aa
Dependencies: #13215 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dlucas):
Hello,
I have some more comments:
- Is there any reason why `cdef` methods in
`skew_polynomial_finite_field.pyx` are not doctested?
- In the same module, a lot of methods do not respect documentation
conventions. See `cdef SkewPolynomial_finite_field_dense _rgcd` for
instance, whose documentation is this single sentence: `Fast right gcd.`.
Some methods (e.g. `_rightpow_`, `_leftpow`) do not even have this
`Return(s) blah blah` line which explains what they're supposed to do...
- `skew_polynomial_finite_field.pyx`'s title is `This module implements
skew polynomials over finite fields.`. I think it should be changed to
`Skew polynomials over finite fields`, or something equivalent.
- A lot of elements are not properly formatted in docstrings of
`skew_polynomial_finite_field.pyx`: it should be `<double
backtick>self<double backtick>` instead of `self`, etc.
- In `class SkewPolynomialRing_finite_field`, docstring of `twist_map` is
not helpful as it says `Return the twist map`.
--
Ticket URL: <https://trac.sagemath.org/ticket/21088#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
