#6595: 'modified sage library code' fails at c_lib if /opt/SUNWspro/bin/CC can
be
found. (SCons issue)
------------------------+---------------------------------------------------
Reporter: drkirkby | Owner: tbd
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-4.3
Component: solaris | Keywords: scons SUNWspro SunStudio
Work_issues: | Author:
Upstream: N/A | Reviewer:
Merged: |
------------------------+---------------------------------------------------
Changes (by drkirkby):
* status: needs_review => positive_review
Comment:
My 'sage -upgrade' seems to have hit a problem, as this library is built
twice. The first time it builds fine, with no warnings g++.
The second time it has the same issues as before - same warning, from the
Sun compiler 'CC'. I can only assume something is a bit messed up here.
It's clearly patched ok, but I must have left-over code being built.
Note however, there is no -Wall option, so we wont catch many warnings
from gcc/g++. It might be worth adding that at some point in the future,
given you have noticed two serious bugs in what is a relatively small
amount of code. But I don't know how to enable the warnings with SCons.
I looked at your changes to the C and C++ code, and they look fine. I
don't fully understand what that code is supposed to do, but clearly
computing an answer, then not bothering to return it was rather obviously
a mistake, which should have been caught with a compiler warning.
Luckily the Sun compiler was not so forgiving as g++, so allowed those
errors to be found.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6595#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
