#7095: os x 10.6 port -- numerous mysterious errors caused by weird "abort trap"
issue
-----------------------+----------------------------------------------------
   Reporter:  was      |       Owner:  tbd                                      
                
       Type:  defect   |      Status:  needs_work                               
                
   Priority:  blocker  |   Milestone:  sage-4.3.1                               
                
  Component:  porting  |    Keywords:                                           
                
Work_issues:           |      Author:  Craig Citro, John Palmieri, Francis 
Clarke, William Stein
   Upstream:  N/A      |    Reviewer:  David Kirkby                             
                
     Merged:           |  
-----------------------+----------------------------------------------------

Comment(by jhpalmieri):

 Replying to [comment:39 drkirkby]:
 >  * My patch removed 'set -e', which removed some degree of error
 checking. But I overcome that by adding an additional error check that the
 Itanium patch was installed (see lines line 100-103 of my patch). That has
 have been lost.

 >  An extra line added in spkg-install {{{cp patches/readline.c-spacebug
 src/Modules/readline.c}}}
 >  has no check for an error. I think it would be wise to add one.

 Right now there is an "if ... then ... else" block which deals with both
 readline issues, and after this block, it says
 {{{
 if [ $? -ne 0 ]; then
     echo "Error copying patched readline.c"
     exit 1
 fi
 }}}

 Shouldn't this perform the appropriate error check if either of the
 readline issues fails?  I don't really know shell scripts, so maybe we
 need "[ $? -ne 0 ]" within the "if" part and also within the "else" part.

 >  * The spelling of my name in SPKG.txt is incorrect. I would not bother
 mentioning it, but since this update removes some of the error checking,
 you might as well fix it at the same time as fixing the error checking.

 Oops, sorry, that's easy enough to fix.  I'll post the new version just
 changing this.  Let me know about the readline issues.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7095#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to