#5107: incorrect trailing digits for continued fraction
--------------------------------+-------------------------------------------
Reporter: robertwb | Owner: somebody
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.3.1
Component: basic arithmetic | Keywords:
Work_issues: | Author:
Upstream: N/A | Reviewer:
Merged: |
--------------------------------+-------------------------------------------
Changes (by was):
* status: new => needs_review
* upstream: => N/A
Comment:
Hi,
I've looked through this carefully.
1. I strongly disagree that any of the examples above are bugs. They are
the result of users misunderstanding what the {{{continued_fraction}}}
function is supposed to do. This may be partly because that function has
0 documentation!
2. Regarding speed: correctness is much more important for starters, and
it's also good to have a precise definition of exactly what is being
computed. That is impossible to do in PARI, mainly because of how PARI's
precision can't be set exactly in bits. This is difficult to appreciate
without the function continued_fraction being documented. The right way
to make this function faster is to just reimplement
continued_fraction_list in Cython.
So, I've attached a patch that:
1. Brings the coverage of contfrac.py to 100%.
2. Explains in detail what continued_fraction is actually supposed to
compute.
3. Changes the docs in the whole contfrac.py file to use ReST
formatting.
It doesn't change what anything actually does in any significant way.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5107#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
