#7532: "return NotImplementedError" in ring.pyx
-------------------------------+--------------------------------------------
Reporter: was | Owner: cremona
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.1
Component: elliptic curves | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by jhpalmieri):
Hi John,
I think your patch really belongs on #7535, not here, since it fixes a
doctest which was broken by the patches there. My comment was, if I make
another change, this time to ring.pyx (see the new patch), then I get the
following doctest failures:
{{{
$ sage -t -long
/Applications/sage/devel/sage/sage/schemes/elliptic_curves/monsky_washnitzer.py
sage -t -long
"devel/sage/sage/schemes/elliptic_curves/monsky_washnitzer.py"
**********************************************************************
File
"/Applications/sage/devel/sage/sage/schemes/elliptic_curves/monsky_washnitzer.py",
line 1549:
sage: A = monsky_washnitzer.matrix_of_frobenius(Q, p, M) # long
time
Exception raised:
Traceback (most recent call last):
File "/Applications/sage/local/bin/ncadoctest.py", line 1231, in
run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/Applications/sage/local/bin/sagedoctest.py", line 38, in
run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/Applications/sage/local/bin/ncadoctest.py", line 1172, in
run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_32[66]>", line 1, in <module>
A = monsky_washnitzer.matrix_of_frobenius(Q, p, M) # long
time###line 1549:
sage: A = monsky_washnitzer.matrix_of_frobenius(Q, p, M) # long
time
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/monsky_washnitzer.py", line 1606, in
matrix_of_frobenius
F0_reduced = reduce_all(Q, p, F0_coeffs, offset)
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/monsky_washnitzer.py", line 1023, in
reduce_all
exact_form = reduce_negative(Q, p, coeffs, offset, exact_form)
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/monsky_washnitzer.py", line 757, in
reduce_negative
m = helper_matrix(Q).list()
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/monsky_washnitzer.py", line 689, in
helper_matrix
return (1/D) * matrix(Q.base_ring(), 3, 3,
File "element.pyx", line 1326, in
sage.structure.element.RingElement.__div__
(sage/structure/element.c:10897)
File "coerce.pyx", line 707, in
sage.structure.coerce.CoercionModel_cache_maps.bin_op
(sage/structure/coerce.c:6073)
File "coerce.pyx", line 1178, in
sage.structure.coerce.CoercionModel_cache_maps.get_action
(sage/structure/coerce.c:10911)
File "coerce.pyx", line 1309, in
sage.structure.coerce.CoercionModel_cache_maps.discover_action
(sage/structure/coerce.c:12070)
File "coerce.pyx", line 1346, in
sage.structure.coerce.CoercionModel_cache_maps.discover_action
(sage/structure/coerce.c:12620)
File "ring.pyx", line 933, in
sage.rings.ring.CommutativeRing._pseudo_fraction_field
(sage/rings/ring.c:6321)
File "ring.pyx", line 900, in
sage.rings.ring.CommutativeRing.fraction_field (sage/rings/ring.c:6164)
File "ring.pyx", line 695, in
sage.rings.ring.Ring.is_integral_domain (sage/rings/ring.c:5074)
NotImplementedError
**********************************************************************
File
"/Applications/sage/devel/sage/sage/schemes/elliptic_curves/monsky_washnitzer.py",
line 1551:
sage: B # long
time
Expected:
[1144 + 264*t + 841*t^2 + 1025*t^3 + O(t^4) 176 + 1052*t + 216*t^2 +
523*t^3 + O(t^4)]
[ 847 + 668*t + 81*t^2 + 424*t^3 + O(t^4) 185 + 341*t + 171*t^2 +
642*t^3 + O(t^4)]
Got:
[ 514 927]
[ 702 1036]
**********************************************************************
File
"/Applications/sage/devel/sage/sage/schemes/elliptic_curves/monsky_washnitzer.py",
line 1562:
sage: B.det() # long
time
Expected:
11 + 484*t^2 + 451*t^3 + O(t^4)
Got:
209
**********************************************************************
1 items had failures:
3 of 70 in __main__.example_32
***Test Failed*** 3 failures.
For whitespace errors, see the file
/Users/palmieri/.sage//tmp/.doctest_monsky_washnitzer.py
[20.6 s]
exit code: 1024
}}}
and
{{{
sage -t -long "devel/sage/sage/schemes/elliptic_curves/padics.py"
**********************************************************************
File
"/Applications/sage/devel/sage/sage/schemes/elliptic_curves/padics.py",
line 197:
sage: E.padic_regulator(5, 10)
Exception raised:
Traceback (most recent call last):
File "/Applications/sage/local/bin/ncadoctest.py", line 1231, in
run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/Applications/sage/local/bin/sagedoctest.py", line 38, in
run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/Applications/sage/local/bin/ncadoctest.py", line 1172, in
run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_2[3]>", line 1, in <module>
E.padic_regulator(Integer(5), Integer(10))###line 197:
sage: E.padic_regulator(5, 10)
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/padics.py", line 253, in
padic_regulator
height = self.padic_height(p, prec, check_hypotheses=False)
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/padics.py", line 659, in
padic_height
sigma = self.padic_sigma(p, adjusted_prec, check_hypotheses=False)
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/padics.py", line 1009, in
padic_sigma
f = X.formal_group().differential(N+2) # f = 1 + ... +
O(t^{N+2})
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/formal_group.py", line 360, in
differential
x = self.x(prec+1)
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/formal_group.py", line 253, in x
y = self.y(prec)
File "/Applications/sage/local/lib/python/site-
packages/sage/schemes/elliptic_curves/formal_group.py", line 303, in y
y = -1/w + O(t**prec)
File "element.pyx", line 1326, in
sage.structure.element.RingElement.__div__
(sage/structure/element.c:10897)
File "coerce.pyx", line 707, in
sage.structure.coerce.CoercionModel_cache_maps.bin_op
(sage/structure/coerce.c:6073)
File "coerce.pyx", line 1178, in
sage.structure.coerce.CoercionModel_cache_maps.get_action
(sage/structure/coerce.c:10911)
File "coerce.pyx", line 1309, in
sage.structure.coerce.CoercionModel_cache_maps.discover_action
(sage/structure/coerce.c:12070)
File "coerce.pyx", line 1346, in
sage.structure.coerce.CoercionModel_cache_maps.discover_action
(sage/structure/coerce.c:12620)
File "ring.pyx", line 933, in
sage.rings.ring.CommutativeRing._pseudo_fraction_field
(sage/rings/ring.c:6321)
File "ring.pyx", line 900, in
sage.rings.ring.CommutativeRing.fraction_field (sage/rings/ring.c:6164)
File "ring.pyx", line 695, in
sage.rings.ring.Ring.is_integral_domain (sage/rings/ring.c:5074)
NotImplementedError
**********************************************************************
}}}
plus 45 more failures in padics.py (too many to include here), and I
expect failures in sha-tate.py -- currently in the middle of testing and I
have to go teach, so I can't wait for it to finish.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7532#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
