#7532: "return NotImplementedError" in ring.pyx
-----------------------------+----------------------------------------------
Reporter: was | Owner: cremona
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.3.1
Component: elliptic curves | Resolution: fixed
Keywords: | Author: John Cremona
Upstream: N/A | Reviewer: Tim Dumol, John Palmieri
Merged: | Work_issues:
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: Tim Dumol => Tim Dumol, John Palmieri
* author: John Palmieri => John Cremona
Old description:
> {{{
> On Wed, Nov 25, 2009 at 7:26 PM, John H Palmieri <[email protected]>
> wrote:
> > In ring.pyx, there is code like this:
> >
> > if proof:
> > return NotImplementedError
> > else:
> > return False
> >
> > I would think that the second line should say "raise
> > NotImplementedError". (Changing it makes some doctests fail,
> > though.) Is there a good reason for doing "return
> > NotImplementedError"?
>
> That's *definitely* a bug. No question about it.
> }}}
New description:
{{{
On Wed, Nov 25, 2009 at 7:26 PM, John H Palmieri <[email protected]>
wrote:
> In ring.pyx, there is code like this:
>
> if proof:
> return NotImplementedError
> else:
> return False
>
> I would think that the second line should say "raise
> NotImplementedError". (Changing it makes some doctests fail,
> though.) Is there a good reason for doing "return
> NotImplementedError"?
That's *definitely* a bug. No question about it.
}}}
Addendum: apply the patches {{{trac_7532.patch}}} and
{{{trac_7532-rings.patch}}}. Depends on #7535.
--
Comment:
Looks good, all tests pass. Thanks for the fix, John.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7532#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
