#8112: flint fails to build in Open Solaris x64 as 64 bit if CFLAGS is not set
----------------------------+-----------------------------------------------
Reporter: jsp | Owner: drkirkby
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.3.2
Component: porting | Keywords:
Author: Jaap Spies | Upstream: N/A
Reviewer: David Kirkby | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by jsp):
Replying to [comment:2 drkirkby]:
> It's not clear to me what is intended here.
>
> * There is no such thing as CXXFLAG. Did you mean CXXFLAGS?
I don't see anything alike in the patch file!?
> * The point of CFLAG64 is that it would be set to whatever flag is
needed to build 64 bit executables with a C compiler, which -m64 in most,
but not all cases.
> * The point of CXXFLAG64 is that it would be set to whatever flag is
needed to build 64 bit executables with a C++ compiler, which -m64 in
most, but not all cases.
>
>
> If Flint will build by setting the environment variables CFLAG64 and
CXXFLAG64 to -m64, then I would not bother patching Flint at all. Just set
those two environments variables. They will not mess up the build process
in any way, and since they are variables, they could be set to something
else. Setting CFLAGS is known to cause problems, but setting CFLAG64 or
CXXFLAG64 will not cause any problems.
>
Are you shure flint will build that way?
> If you do need to patch this again, then you can remove this code:
>
> {{{
> ./test_gcc_version.sh
> if [ $? -ne 0 ]; then
> echo "GCC version less than 3.4.0"
> echo "Flint will not be able to compile successfully"
> exit 1
> fi
> }}}
>
> since 'prereq' will ensure that gcc is at least 4.0.1. That also means
the file test_gcc_version.sh can be removed, as it is now redundant.
>
> Thinking about this 64-bit patching process in general, it is better to
simply use CFLAG64 and CXXFLAG64 rather than -m64, and simply document the
user must type
>
> {{{
> $ CFLAG64=-m64
> $ export CFLAG64
> $ CXXFLAG64=-m64
> $ export CXXFLAG64
> }}}
>
> until such time as sage-env is updated. At which point, that will be
unnecessary to do. That will avoid -m64 ever having to be hard-coded
again, which is a good thing, as not all compilers accept that flag.
>
> I suspect this ticket can be closed as 'wontfix' as no fixes are needed,
but I may be wrong.
>
We'll see.
> Dave
>
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8112#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
