#8232: cmp function for words is broken
-----------------------------+----------------------------------------------
Reporter: slabbe | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.3
Component: combinatorics | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by abmasse):
Hi, Sébastien !
I finally got some time to look at your patch and everything seems fine,
code makes sense, documentation builds without warning and the bugs
mentionned in the description are fixed.
The only observation I would make is that it seems costly to use all those
`try` and `catch` blocks in the `__cmp__(...)` function. Don't you think
it may be better to use the `izip_longest` function of the `itertools`
library, which fills the shortest iterator with a special character ? This
way, you would only have to check if that character appear in `self_it or
in `other_it` to choose which one is the smallest w.r.t the lexicographic
order.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8232#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
