#8232: cmp function for words is broken
---------------------------------------+------------------------------------
Reporter: slabbe | Owner: sage-combinat
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.3.3
Component: combinatorics | Keywords:
Author: Sébastien Labbé | Upstream: N/A
Reviewer: Alexandre Blondin Massé | Merged:
Work_issues: |
---------------------------------------+------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => Alexandre Blondin Massé
* author: => Sébastien Labbé
Comment:
Never mind my last observation, it seems more complicated to use
`izip_longest` since you have to choose a different character from the one
occurring in the compared words... and there is no clean way that comes up
to me since the letters of word can be any object.
Anyway, the goal of the patch is reached, the documentation builds
correctly, all tests pass, the bugs are fixed.
Positive review !
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8232#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
