#8420: new feature : class of perfect matching
------------------------------+---------------------------------------------
Reporter: vferay | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: combinatorics | Keywords: perfect matching
Author: Valentin Feray | Upstream: N/A
Reviewer: Florent Hivert | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by vferay):
* status: needs_work => needs_review
Comment:
Hi Florent,
thanks a lot for this deep review of my patch and don't apologize for
the quantity of remarks, it's a very good thing for me to learn. Moreover,
you had done already a big part of the needed corrections, so thanks for
that also. I have done the remaining corrections and I think the patch is
ready for a new review.
Best,
Valentin
More specific comments:
- concerning the imports (on the beginning of the file or of the
function), Nicolas (Thiery) told me to try to put the high-level imports
(so, in my case, I think it would be Partition, Permutation, Matrix) at
the beginning of the functions to prevent apparition of loops...
- I did the change you requested:
* I created a loops_iterator and a function which gives the list of the
loops.
* The correctness of the data given to create a perfect matching is
checked when the syntax PerfectMatching(...) is used.
- I also added some new methods:
* nestings_iterator and related function: the code is very similar to the
one of crossings_iterator and I saw in literature that this notion appears
often.
* coset-type for permutations, which was one of the thing I was interested
in.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8420#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
