#8420: new feature : class of perfect matching
------------------------------+---------------------------------------------
Reporter: vferay | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: combinatorics | Keywords: perfect matching
Author: Valentin Feray | Upstream: N/A
Reviewer: Florent Hivert | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by vferay):
Hi Florent!
Thanks for this new review. The patch seems ready, except for two small
things:
- line 144 of the file perfect_matching.py, it is written in the doc
`PerfectMatchings(objects)(data)`.
Should it not be
``PerfectMatchings(objects)(data)``.
as this is sage code?
- second: the function now called
hyperoctahedral_double_coset_type
(which name is fine like this by the way)
does not return a PerfectMatching as you suggest in the doc,
but a partition.
As I am learning, I would like to know what is the best way to deal with
very small changes like that:
- to do a new review patch as in the case of big changes?
- to let you do these changes and switch to positive review?
- to do the changes myself and switch to positive review? (but I believe
this is not a good idea as I am not supposed to write in your patch)
Another thing that I did not know how to do was the following:
I remember that you said something about compiling the documentation to
check that it is well written. How does it work?
Yours,
Valentin
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8420#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
