#8420: new feature : class of perfect matching
------------------------------+---------------------------------------------
Reporter: vferay | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: combinatorics | Keywords: perfect matching
Author: Valentin Feray | Upstream: N/A
Reviewer: Florent Hivert | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by hivert):
Hi Valentin !
I just uploaded a review patch. It purpose is:
- fix some doc issues (references, indentation, ...).
- remove the methods {{{__init__}}} in {{{PerfectMatching}}} since it was
properly inherited;
- add a few doctests;
- change the name of {{{coset_type}}} to
{{{hyperoctahedral_double_coset_type}}}.
I need you (or anyone else) to review this patch and tell me if the change
of name suits to you. If it does and if my patch is correct, you can set
positive review to this ticket. Your patch is fine for me.
Some tip for the doc:
- inside single back quote {{{`...`}}} you put things in LaTeX format. so
beware of "{" and "}" vanishing...
- in a bullet list you should indent the lines after the bullet:
{{{
- plenty of text; plenty of text; plenty of text;
plenty of text; plenty of text;
plenty of text;
- More text
}}}
and not
{{{
- plenty of text; plenty of text; plenty of text;
plenty of text; plenty of text;
plenty of text;
- More text
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8420#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
