#8500: Add the set of TransitiveGroups
-----------------------------+----------------------------------------------
Reporter: nborie | Owner: nborie
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.3.4
Component: group_theory | Keywords: transitive group
Author: Nicolas Borie | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* author: => Nicolas Borie
Comment:
Wow,that was quick, thanks!
I browsed through the patch, which looks good. Some minor comments before
I do the final review:
- Change "trac 8500 Add the finite enumerated set of TransitiveGroups" to
"#8500 Add the enumerated set of TransitiveGroups"
- Keep number_of_transitive_groups a private function (i.e. not in
all.py)
- TransitiveGroups() would better model the mathematical set of all
transitive groups, even if this is only partially implemented. Hence
TransitiveGroups() should be in InfiniteEnumeratedSets (and therefore
TransitiveGroups().cardinality() will return infinity). As a side effect,
the #long time should not be needed anymore for the
TestSuite(TransitiveGroups()).run().
- You may actually want to implement TransitiveGroups() as a
DisjointUnionOfEnumeratedSets, which should essentially do all the work
for you.
-
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8500#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
