#4793: Update lcalc to the new upstream 1.23 [with spkg]
------------------------+---------------------------------------------------
Reporter: mabshoff | Owner: rishi
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: packages | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by rishi):
* status: needs_work => needs_review
Comment:
Replying to [comment:12 drkirkby]:
> Hi,
> there are a few problems with spkg-install, which don't reflect how Sage
is currently being built.
>
> * You said on #5396 "One more thing- I've also cleaned up my makefile a
bit, and, in the source, got rid of depreciated headers and unused
variables." Did you notice that your Makefile is being overwritten, by the
following line:
> {{{
> cp ../../patches/Makefile.sage Makefile
> }}}
> Are those changes appropriate? But looking at your own Makefile, I see
still see options to suppress warnings messages.
> * -Wa,-W is designed to suppress warnings from the assembler, which
fails if the Sun assembler is used. (That's why I had to re-write part of
your makefile before).
> * -Wno-deprecate is designed to suppress warnings about depreciated
headers.
Please see what the package does. I have not made any changes to original
Makefile, only to Makefile.sage
>
> A few more things.
>
I took the old spkg-install and added what I needed. I did not change what
ever happened else where, so the person who changed those should have
changed this prereq in lcalc spkg. This includes everything below. I am
changing status to needs review.
> * Don't bother checking for SAGE_FORTRAN_LIB, as it is tested in the
'prereq' script.
> * Don't bother checking for SAGE_FORTRAN, as again prereq takes care of
that.
> * Don't bother checking if the GNU and Sun compilers are mixed - that
is taken care of elsewhere.
> * The line:
> {{{
> echo "Building a 32-bit version of lcalc"
> }}}
>
> is incorrect, as some systems build 64-bit by default, and so the
lack of a -m64 flag does not imply a 32-bit build.
> * The line:
> {{{
> if [ "x$SAGE64" = "xyes" ] || [ "x$SAGE64" = "x1" ] ; then
> }}}
> can be simplified to
> {{{
> if [ "x$SAGE64" = xyes ] ; then
> }}}
>
> as SAGE64 can only be unset, set to 'yes' or set to 'no' - any other
combination is not permitted.
>
> Are there any self-tests of this package? If so, it should have a spkg-
check too, but of course, if there are no self-tests, then that is
inappropriate.
>
> Dave
>
>
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4793#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
