#4793: Update lcalc to the new upstream 1.23 [with spkg]
------------------------+---------------------------------------------------
Reporter: mabshoff | Owner: rishi
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: packages | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by was):
Hi David,
The command "hg annotate" is helpful in clarifying the above issues. Let
me give you a tutorial about how that command works. Doing
{{{
hg annotate spkg-install |grep FORTRAN
}}}
yields that changeset 22 added all the FORTRAN stuff you're complaining
about:
{{{
changeset: 22:c7e7606b574d
user: David Kirkby <[email protected]>
date: Tue Sep 15 07:41:31 2009 -0700
summary: trac #6609: don't pass GNU flags directly to the Sun
assembler
}}}
You also state you added this in the SPKG.txt:
{{{
=== lcalc-20080205.p3 (David kirkby, 15th September, 2009) ===
* A general tidy-up/improvement in many ways, including:
...
* Check that the C, C++ and Fortran compilers are not a mix of Sun and
GNU
}}}
Your comment about
{{{
* The line:
echo "Building a 32-bit version of lcalc"
is incorrect, as some systems build 64-bit by default, and so the
lack of a -m64 flag does not imply a 32-bit build.
}}}
is also a complaint about code that you added in patch 22.
So you are currently complaining about and rejecting Rishi's spkg based
entirely on problems that you introduced in the spkg.
Thus I don't think all (any?) of your complaints are valid.
I'll work with Rishi and Mike Hansen today to get this spkg in. Since you
clearly don't like many of the changes you introduced in changeset 22, I
encourage you to create a new trac ticket to remove those changes from say
the next version of lcalc. Then Rishi (who should be the official package
maintainer -- Rishi: you may add yourself as such in SPKG.txt) can make
those changes.
-- William
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4793#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
