#8523: Optional package p_group_cohomology-1.2 fails to install on Solaris 10
SPARC
---------------------------------+------------------------------------------
Reporter: drkirkby | Owner: SimonKing
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: optional packages | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by SimonKing):
Replying to [comment:8 dimpase]:
> Replying to [comment:7 SimonKing]:
In http://sagemath.org/packages/optional/p_group_cohomology-1.2.spkg (do
you talk about the same repository?) hg reports
{{{
? mtxoriginal/COPYING
? mtxoriginal/README
? mtxoriginal/bin/Makefile
...
}}}
Ah, now I understand. In fact, these files do not belong into the hg
repository, IMO.
The `mtxoriginal/` folder is just a reference to the original `C-MeatAxe`,
as it was downloaded from upstream. And if I remember correctly, as a rule
of thumb, any SPKG should provide third party code in its original form.
On the other hand, look into the `src/` folder. As a subfolder, you will
find another copy of `C-MeatAxe`. This one contains many modifications
made by David Green and myself. Since these modifications are, to some
extent, original code, I've put it under version control: You will find
that this subfolder ''is'' in the hg repository.
Changes to third party code should be made transparent, and I thought that
if there are many changes then the resulting large diff file would be less
transparent than having both versions simultaneously: The version from
third party, and our modified version.
Only the code in `src/` is compiled, and it may change when upgrading the
package. But the stuff in `mtxoriginal/` is not compiled, and it will not
be touched. So, there is no point of putting `mtxoriginall/` under version
control.
> Moreover in SPKG.txt you say {{{ Note that most of the code is
original. Therefore we included the files from src into the Mercurial
repository. }}}
Exactly. And it also says:
{{{
The package includes a modified version of the Aachen C-MeatAxe. Since the
changes are major, we included the modified sources into the Mercurial
repository. A MeatAxe version that comes closest to what we started with
is provided in the folder mtxoriginal.
}}}
I thought this is clear enough.
IIRC, the developer's guide says that the `src/` folder of an SPKG should
''not'' be under version control. I asked why, and got the reply that
''normally'' it contains third party code that is simply dropped in, so
that version control does not make sense.
Here, we have original code, and therefore `src/` is under version
control, in contrast to most other SPKGs.
Probably I should better add a `.hgignore`, so that `mtxoriginal/` gets
ignored...
Best regards,
Simon
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8523#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
