#7608: upgrade NetworkX to version 1.0.1
--------------------------------------------------------+-------------------
Reporter: ylchapuy | Owner: jason
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-4.4
Component: graph theory | Keywords:
Author: Gregory McWhirter | Upstream: N/A
Reviewer: Minh Van Nguyen, Rob Beezer, Jason Grout | Merged:
Work_issues: |
--------------------------------------------------------+-------------------
Changes (by mvngu):
* status: positive_review => needs_work
Old description:
> This implies a lot of modifications in graph_backends.py to respect the
> new API.
>
> Updated spkg is at
>
> http://sage.math.washington.edu/home/mvngu/spkg/standard/networkx/networkx-1.0.1.spkg
>
> Apply only:
>
> * [http://trac.sagemath.org/sage_trac/attachment/ticket/7608/trac_7608
> -networkx-mega.patch trac_7608-networkx-mega.patch]
New description:
This implies a lot of modifications in graph_backends.py to respect the
new API.
Updated spkg is at
http://sage.math.washington.edu/home/mvngu/spkg/standard/networkx/networkx-1.0.1.spkg
Apply only:
* [http://trac.sagemath.org/sage_trac/attachment/ticket/7608/trac_7608
-networkx-mega.2.patch trac_7608-networkx-mega.2.patch]
--
Comment:
Replying to [comment:57 rbeezer]:
> I'm going to change this to "positive review" and if anybody feels
different they can flip it back.
I took Sage 4.4.rc0, replaced its NetworkX spkg with the upgraded one on
this ticket, and applied the patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/7608/trac_7608
-networkx-mega.patch trac_7608-networkx-mega.patch] to the package
sage-4.4.rc0.spkg. I then rebuilt Sage 4.4.rc0 from scratch with these
modifications. The build went fine, but doctesting resulted in the
following failures:
{{{
sage -t -long devel/sage/sage/graphs/generic_graph.py
**********************************************************************
File "/dev/shm/mvngu/sandbox/sage-4.4.rc0-7608-networkx/devel/sage-
main/sage/graphs/generic_graph.py", line 6828:
sage:
(graphs.FruchtGraph()).clustering_coeff(nbunch=[0,1,2],with_labels=True,weights=True)
Expected:
({0: 0.33333333333333331, 1: 0.33333333333333331, 2: 0.0}, {0:
0.083333333333333329, 1: 0.083333333333333329, 2: 0.083333333333333329})
Got:
({0: 0.33333333333333331, 1: 0.33333333333333331, 2: 0.0}, {0:
0.33333333333333331, 1: 0.33333333333333331, 2: 0.33333333333333331})
**********************************************************************
File "/dev/shm/mvngu/sandbox/sage-4.4.rc0-7608-networkx/devel/sage-
main/sage/graphs/generic_graph.py", line 5469:
sage: graphs.DodecahedralGraph().edges()
Expected:
[(0, 1, None), (0, 10, None), (0, 19, None), (1, 2, None), (1, 8,
None), (2, 3, None), (2, 6, None), (3, 4, None), (3, 19, None), (4, 5,
None), (4, 17, None), (5, 6, None), (5, 15, None), (6, 7, None), (7, 8,
None), (7, 14, None), (8, 9, None), (9, 10, None), (9, 13, None), (10, 11,
None), (11, 12, None), (11, 18, None), (12, 13, None), (12, 16, None),
(13, 14, None), (14, 15, None), (15, 16, None), (16, 17, None), (17, 18,
None), (18, 19, None)]
Got:
[(0, 1, {}), (0, 10, {}), (0, 19, {}), (1, 2, {}), (1, 8, {}), (2, 3,
{}), (2, 6, {}), (3, 4, {}), (3, 19, {}), (4, 5, {}), (4, 17, {}), (5, 6,
{}), (5, 15, {}), (6, 7, {}), (7, 8, {}), (7, 14, {}), (8, 9, {}), (9, 10,
{}), (9, 13, {}), (10, 11, {}), (11, 12, {}), (11, 18, {}), (12, 13, {}),
(12, 16, {}), (13, 14, {}), (14, 15, {}), (15, 16, {}), (16, 17, {}), (17,
18, {}), (18, 19, {})]
**********************************************************************
2 items had failures:
}}}
I have patched this failure, as contained in
[http://trac.sagemath.org/sage_trac/attachment/ticket/7608/trac_7608-more-
doctest-fixes.patch trac_7608-more-doctest-fixes.patch]. This patch is
folded into the original mega patch to get the new mega patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/7608/trac_7608
-networkx-mega.2.patch trac_7608-networkx-mega.2.patch]. Anyone up for a
further trivial review of this new mega patch?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7608#comment:59>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
