#8192: Update PolyBoRi to newest upstream release
--------------------------+-------------------------------------------------
 Reporter:  malb          |         Owner:  PolyBoRi                       
     Type:  enhancement   |        Status:  closed                         
 Priority:  major         |     Milestone:  sage-4.4.1                     
Component:  packages      |    Resolution:  fixed                          
 Keywords:                |        Author:  Alexander Dreyer, Burcin Erocal
 Upstream:  N/A           |      Reviewer:  Martin Albrecht                
   Merged:  4.4.1.alpha1  |   Work_issues:                                 
--------------------------+-------------------------------------------------

Comment(by burcin):

 Hi Willem Jan,

 The crashes are probably caused by the fact that I disabled the code that
 statically links polybori in the new package. IIRC, we were doing that
 exactly because of these double free errors. We tested the new package on
 different platforms, and didn't see the crashes, so we assumed the problem
 was fixed.

 I don't have time to reproduce the problem, or test new packages at the
 moment. Can you try enabling the static build and try again?

 From the diff of the changes (of an earlier version of the package in
 Alexander Dreyer's home dir), this looks like the relevant change:

 {{{
 diff --git a/patches/SConstruct b/patches/SConstruct
 --- a/patches/SConstruct
 +++ b/patches/SConstruct
 @@ -561,7 +581,7 @@
  gb_src = [GBPath('src', source) for source in gb_src]
  if not(external_m4ri):
     gb_src += m4ri
 -gb=env.StaticLibrary(GBPath('groebner'), gb_src+[libpb])
 +gb=env.StaticLibrary(GBPath('groebner'), gb_src)#+[libpb])

  #print "gb:", gb, dir(gb)
  #sometimes l seems to be boxed by a list
 }}}


 BTW, this also looks suspect to me:

 {{{
 diff --git a/patches/SConstruct b/patches/SConstruct
 --- a/patches/SConstruct
 +++ b/patches/SConstruct
 @@ -327,7 +350,7 @@
  Help(opts.GenerateHelpText(env))

  have_l2h = have_t4h = False
 -external_m4ri = True
 +external_m4ri = False

  if not env.GetOption('clean'):
      conf = Configure(env)
 }}}

 Many thanks for looking into this.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8192#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to