#8906: Optional package for gap3
---------------------------------+------------------------------------------
Reporter: mrobado | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.2
Component: optional packages | Keywords: gap3
Author: Marco Robado | Upstream: N/A
Reviewer: Burcin Erocal | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by burcin):
* status: new => needs_work
* reviewer: => Burcin Erocal
Comment:
Thanks a lot for the package, and a good example of how to write `spkg-
install` in Python.
Here are a few comments:
* Version numbers for the GAP4 package are of the form gap-4.4.10.p17, so
we should name this gap.3.4.4.p0 and keep increasing the "patch level" at
the end for updates.
* The package has a single mercurial repository at the top, which
contains spkg-install, SPKG.txt, etc. and the GAP3 source files. The
convention is to keep two separate repositories, one with only "packaging"
material, spkg-install and so on, another one to track changes to the
upstream sources.
* Does GAP3 have a test suite? Can we add an spkg-check which runs this?
Another option is to copy the spkg-check which just tries to start GAP
from the spkg mentioned in comment:9:ticket:8380.
* SPKG.txt should be based on the template here:
http://wiki.sagemath.org/spkgTemplate
In particular:
* the changelog should have an entry conforming to the standard
* TODO list (in the file TODO) should be moved in the SPKG.txt
* There should be an explanation of what changes were made to the
upstream sources, even though they are already documented in the mercurial
repository log.
* SPKG.txt should note that src/bin/gap.sh hardcodes version `gap3r4p4`
in the `GAP_DIR` variable
* I don't see why these lines at the end of `spkg-install` are necessary:
{{{
if not os.path.exists(gap3_base):
os.makedirs(gap3_base)
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8906#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
