#8906: Optional package for gap3
---------------------------------+------------------------------------------
Reporter: mrobado | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.2
Component: optional packages | Keywords: gap3
Author: Marco Robado | Upstream: N/A
Reviewer: Burcin Erocal | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by mvngu):
* status: positive_review => needs_work
Comment:
Some problems with gap-3.4.4.p0.spkg:
1. All changes have not been checked in:
{{{
#!sh
[mv...@sage gap-3.4.4.p0]$ hg status
M SPKG.txt
? spkg-check
}}}
You must check in all changes.
1. The license file `COPYING` needs to go under the directory `src/`.
1. The directory `src/` contains one package within another:
{{{
#!sh
[mv...@sage src]$ pwd
/home/mvngu/spkg/optional/gap/gap-3.4.4.p0/src
[mv...@sage src]$ ls
bin description12 description4 description8 grp sml tom
description1 description13 description5 description9 htm src tst
description10 description2 description6 doc lib tbl two
description11 description3 description7 etc pkg thr utl
[mv...@sage src]$ ls src
agcollec.c description12 function.c pcpresen.c record.h
tietze.h
agcollec.h description13 function.h pcpresen.h scanner.c tom
aggroup.c description2 gap.c permutat.c scanner.h tst
aggroup.h description3 gasman.c permutat.h set.c two
bin description4 gasman.h pkg set.h
unknown.c
blister.c description5 grp plist.c sml
unknown.h
blister.h description6 htm plist.h src utl
coding.c description7 idents.c polynom.c statemen.c
vecffe.c
coding.h description8 idents.h polynom.h statemen.h
vecffe.h
costab.c description9 integer.c range.c string.c
vector.c
costab.h doc integer.h range.h string.h
vector.h
cyclotom.c etc lib rational.c system.c
word.c
cyclotom.h eval.c list.c rational.h system.h
word.h
description1 eval.h list.h read.c tbl
description10 finfield.c Makefile read.h thr
description11 finfield.h Makefile.orig record.c tietze.c
}}}
1. You don't have any patches on top of the upstream GAP 3 package, so
you need to start the spkg numbering at `gap-3.4.4.spkg`, not at
`gap-3.4.4.p0.spkg`. The name `gap-3.4.4.p0.spkg` implies that you have a
patch to be applied on top of the upstream GAP 3 package. See this chapter
[http://www.sagemath.org/doc/developer/producing_spkgs.html Producing New
Sage Packages] and chapter
[http://www.sagemath.org/doc/developer/patching_spkgs.html Patching a Sage
Package] of the Developer's Guide.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8906#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
