#8906: Optional package for gap3
---------------------------------+------------------------------------------
Reporter: mrobado | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.2
Component: optional packages | Keywords: gap3
Author: Marco Robado | Upstream: N/A
Reviewer: Burcin Erocal | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by burcin):
Hi Minh,
Replying to [comment:4 mvngu]:
> Some problems with gap-3.4.4.p0.spkg:
>
> 1. All changes have not been checked in:
> {{{
> #!sh
> [mv...@sage gap-3.4.4.p0]$ hg status
> M SPKG.txt
> ? spkg-check
> }}}
> You must check in all changes.
> 1. The license file `COPYING` needs to go under the directory `src/`.
Fair enough, I didn't check these again myself. Note that the COPYING file
doesn't exist in the original gap3 distribution. We decided to make one
after it took us a while to discover the license has a non-commercial use
restriction.
> 1. The directory `src/` contains one package within another:
This is just how the gap3 source is laid out. There are gap library files,
and gap packages in the other directories. I don't see why this is a
problem.
> 1. You don't have any patches on top of the upstream GAP 3 package, so
you need to start the spkg numbering at `gap-3.4.4.spkg`, not at
`gap-3.4.4.p0.spkg`. The name `gap-3.4.4.p0.spkg` implies that you have a
patch to be applied on top of the upstream GAP 3 package.
What is in the spkg is very far from the original gap3 distribution. The
changes couldn't be tracked with patches, so there is a mercurial
repository in the src directory. Marco did a tremendous job creating a GAP
package which actually compiles and works on different platforms, and
includes the latest versions of various GAP packages still being
maintained.
I agree with your points 1 and 2, but IMHO 3 and 4 are not problems that
need to be addressed before this is accepted.
Thanks. [[BR]]
Burcin
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8906#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
