#8781: Overfull graph (and a bug in edge_coloring)
-------------------------------+--------------------------------------------
   Reporter:  ncohen           |       Owner:  jason, ncohen, rlm
       Type:  enhancement      |      Status:  needs_review      
   Priority:  major            |   Milestone:  sage-4.4.2        
  Component:  graph theory     |    Keywords:                    
     Author:  Nathann Cohen    |    Upstream:  N/A               
   Reviewer:  Minh Van Nguyen  |      Merged:                    
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by ncohen):

  * status:  needs_info => needs_review


Old description:

> This patch defines the (very short) function is_overfull
> (http://en.wikipedia.org/wiki/Overfull_graph), and updates the
> edge_coloring function to support it.
>
> I also fixed a mistake in this code : I had mixed g.order() with
> max(g.degree()) for complete graphs ^^;
>
> Nathann

New description:

 This patch defines the (very short) function is_overfull
 (http://en.wikipedia.org/wiki/Overfull_graph), and updates the
 edge_coloring function to support it.

 I also fixed a mistake in this code : I had mixed g.order() with
 max(g.degree()) for complete graphs ^^;

 Requires #8892

 Nathann

--

Comment:

 Oops.... That's totally unrelated, and is caused by the recent upgrade of
 NetworkX. The default graphs from NetworkX (of which ClawGraph() is an
 example) now have {} instead of None as default edge labels... And as {}
 is not hashable, Sage does not like to find it as part of a dictionary key
 ;-)

 There was already a patch waiting for review to fix it, which is #8892,
 but I had forgotten this file and only fixed generic_graph and graph...
 Well, I updated that patch, which is now a dependency of this very one,
 and fixes the bug you found.

 Thank you very much Minh, and sorry again for that :-)

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8781#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to