#8781: Overfull graph (and a bug in edge_coloring)
-------------------------------+--------------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4.3
Component: graph theory | Keywords:
Author: Nathann Cohen | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Old description:
> This patch defines the (very short) function is_overfull
> (http://en.wikipedia.org/wiki/Overfull_graph), and updates the
> edge_coloring function to support it.
>
> I also fixed a mistake in this code : I had mixed g.order() with
> max(g.degree()) for complete graphs ^^;
>
> Requires #8892
>
> Nathann
New description:
This patch defines the (very short) function is_overfull
(http://en.wikipedia.org/wiki/Overfull_graph), and updates the
edge_coloring function to support it.
I also fixed a mistake in this code : I had mixed g.order() with
max(g.degree()) for complete graphs ^^;
'''Apply:'''
1. #8166
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/8781/trac_8781.patch
trac_8781.patch]
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/8781/trac_8781-reviewer.patch
trac_8781-reviewer.patch]
--
Comment(by mvngu):
Replying to [comment:3 ncohen]:
> There was already a patch waiting for review to fix it, which is #8892,
but I had forgotten this file and only fixed generic_graph and graph...
I have updated my reviewer patch to include the doctest that resulted in
the failure I reported above. We better make sure it doesn't happen again.
Anyone for a final review of the whole ticket?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8781#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
