#7828: There should be a top-level sign() function.
-----------------------------------+----------------------------------------
   Reporter:  robertwb             |       Owner:  AlexGhitza     
       Type:  defect               |      Status:  positive_review
   Priority:  minor                |   Milestone:  sage-wishlist  
  Component:  algebra              |    Keywords:                 
     Author:  Karl-Dieter Crisman  |    Upstream:  N/A            
   Reviewer:  John Cremona         |      Merged:                 
Work_issues:                       |  
-----------------------------------+----------------------------------------
Changes (by cremona):

  * status:  needs_review => positive_review
  * reviewer:  => John Cremona


Comment:

 Looks good, applies fine to 4.4.3.alpha0 and tests pass.

 I did wonder whether it would be better to return a Sage integer rather
 than an int?

 Also, I looked for places where sgn() was used/defined and found a
 redundant  definition of sgn() in quadratic_forms/extras.py, which I am
 removing in another ticket (#9068).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7828#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to