#7828: There should be a top-level sign() function.
-----------------------------------+----------------------------------------
Reporter: robertwb | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-wishlist
Component: algebra | Keywords:
Author: Karl-Dieter Crisman | Upstream: N/A
Reviewer: John Cremona | Merged:
Work_issues: |
-----------------------------------+----------------------------------------
Changes (by cremona):
* status: positive_review => needs_work
Comment:
Well, I did look for other places where methods sgn() or sign() were
defined; since in fact I have another comment, which is that as well as
looking to see if x has a method sign() you should also look for a method
sgn(). The only thing I found was that function in quadratic_forms, and
that distracted me from making this comment.
I will do the following now, and report back:
1. Apply both your patch and mine at #9068
2. Change the function you changed in two ways: making the return type
Integer and also checking for x.sgn()
3. Test the whole library.
For the moment I have reverted this to "needs work".
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7828#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
