#9177: cddlib has hard-coded gmp path
---------------------------+------------------------------------------------
Reporter: vbraun | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.4
Component: packages | Keywords:
Author: | Upstream: Not yet reported upstream; Will do
shortly.
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
The package installs in 32-bit Solaris SPARC and on 64-bit !OpenSolaris
x64. However, the refresh_autogenerated.sh script has a GNUism:
{{{
pushd autogenerated
for i in `find -type f` ; do cp -a $BUILDDIR/$i $i ; done
popd
}}}
-a is not an POSIX option to 'cp' so will fail:
{{{
kir...@t2:[~/sage-4.4.3/spkg/optional/cddlib-094f.p7/patches] $ cp -a src-
Makefile.am x
cp: illegal option -- a
Usage: cp [-f] [-i] [-p] [...@] f1 f2
cp [-f] [-i] [-p] [...@] f1 ... fn d1
cp -r|-R [-H|-L|-P] [-f] [-i] [-p] [...@] d1 ... dn-1 dn
}}}
See:
http://www.opengroup.org/onlinepubs/009695399/utilities/cp.html
for a list of acceptable options for 'cp'.
Also, other errors I managed to induce:
{{{
Copying autogenerated files from autogenerated
./refresh_autogenerated.sh: pushd: not found
find: illegal option -- t
find: [-H | -L] path-list predicate-list
./refresh_autogenerated.sh: popd: not found
}}}
See http://www.opengroup.org/onlinepubs/009695399/utilities/find.html
for POSIX options to 'find'
pushd and popd are not supported in the /bin/sh on Solaris, though the
usual
{{{
#!/usr/bin/env bash
}}}
will invoke bash, which will support such options.
A couple of minor points.
* It is usual to provide a diff between the files written and those in
the source code, though I must admit I feel they are of very limited use,
as I could create one if I wanted.
* It would be wise to stick the minimum versions of autoconf/automake
needed - there are macros for that. I noticed configure.ac has no such
entry.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9177#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
