#9177: cddlib has hard-coded gmp path
---------------------------+------------------------------------------------
Reporter: vbraun | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.4
Component: packages | Keywords:
Author: | Upstream: Not yet reported upstream; Will do
shortly.
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Comment(by drkirkby):
Replying to [comment:3 vbraun]:
> I updated the http://www.stp.dias.ie/~vbraun/Sage/spkg/cddlib-
094f.p7.spkg to
> * only use portable `cp` options
> * only use portable `find` options
> * removed use of pushd/popd
> * fixed all `autoscan` warnings, including the missing AC_PREREQ
Thank you.
> There is no patch file for the autotools sources since they are all in
patches/ and not in the corresponding directory structure under src/.
Patches would also not be very useful since the new autotools sources are
essentially a complete rewrite.
Fair enough.
The other point I made is that I believe you should use macros that stops
people using an old version of autoconf or automake to rebuild the files,
since I doubt you can be sure your code will work on old versions. See
http://www.gnu.org/software/autoconf/manual/autoconf.html#Versioning
http://www.gnu.org/software/automake/manual/automake.html#API-Versioning
so I would put something like:
{{{
AC_PREREQ([x.y])
AC_INIT
AM_INIT_AUTOMAKE([a.b.c])
}}}
where x.y is the version of autoconf you use and a.b.c is your version of
automake. Then nobody with older versions can remake the files. Unless you
can be sure all your code will work with the very first releases of
autoconf and automake, then I'd add that.
It looks like there are issues on Cygwin, so perhaps while you are making
the other changes, you can add something to stop people remaking the
files with old versions of autoconf or automake.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9177#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
