#9076: plot Arc of circle and ellipse
-----------------------------------+----------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.4.4
Component: geometry | Keywords: plot, arc, ellipse, circle
Author: Vincent Delecroix | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Merged:
Work_issues: |
-----------------------------------+----------------------------------------
Changes (by kcrisman):
* status: needs_review => needs_work
* reviewer: => Karl-Dieter Crisman
Comment:
In general, I like this. Here are some specific suggestions to make it
tip-top.
* line 26 - "an arc", not just "arc"
* There should be some examples for the class def, since that is in
reference
* allowed options docs has circle a couple times rather than arc
* The '_repr_' method should have an explanation of radius, maybe even to
the point of checking whether it is a circle or an ellipse (and then
returning an appropriate string)
* Should be a plot3d method, or open a ticket to add one - though really
one could just ape circle.py with x+r*cos(t*dt) and y+r*sin(t*dt) changed
appropriately - and if not, then we should test the `NotImplementedError`
raised in the base class.
* in arc(), we should have a few changes. First, a few more of the
options should be shown in the examples. Second, I think a 2-uple is a
2-tuple (?). Third, clearly the radii don't need to be floats, thought
presumably they should be nonnegative. Next, the sector should be clearly
pointed out to be a 2-tuple in the input. Finally, of the two examples
shown, the red one isn't! It would be good to give an explicit example of
how angle (as opposed to sector) works, perhaps similarly to the one in
get_min_max_data. One should test the `NotImplementedError` at the end
(under TESTS::, I guess)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9076#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
