#9076: plot Arc of circle and ellipse
-----------------------------------+----------------------------------------
   Reporter:  vdelecroix           |       Owner:  vdelecroix                
       Type:  defect               |      Status:  needs_review              
   Priority:  major                |   Milestone:  sage-4.5                  
  Component:  graphics             |    Keywords:  plot, arc, ellipse, circle
     Author:  Vincent Delecroix    |    Upstream:  N/A                       
   Reviewer:  Karl-Dieter Crisman  |      Merged:                            
Work_issues:                       |  
-----------------------------------+----------------------------------------
Changes (by vdelecroix):

  * status:  needs_work => needs_review


Comment:

 >  * I think that the current algorithm for the bounding box is not the
 same as that in the worksheet, which seems to be pretty good.  The ellipse
 part works; I did find one example where the arc one didn't quite work:

 There was a mistake... this now works on a lot (all?) examples.

 >  * The worksheet is REALLY COOL, by the way; I strongly encourage you to
 add more commentary, turn the graphics into interacts, and advertise it as
 a great way to use Sage to demonstrate basic uses of parametric calculus!

 I tried to enhanced the worksheet. I do not know what I can do more.

 >  * On a related point, the constructor should be as minimal as possible;
 why not wait to float the radii etc. until `_render_on_subplot_()` and
 `get_minmax_data()`?  That would also make the representation string much
 easier on the eyes (and intelligible).

 Here, I disagree because all plotting functions convert in the
 constructor. I do not know why, but for consistency I find it better to do
 this way. An other argument for this option is to get an error as soon as
 possible if the constructor is called with wrong argument.

 I corrected all the other points in the way you suggested.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9076#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to