#9295: Add an spkg-check file for Python
----------------------------+-----------------------------------------------
   Reporter:  drkirkby      |       Owner:  tbd       
       Type:  defect        |      Status:  new       
   Priority:  major         |   Milestone:  sage-4.4.4
  Component:  spkg-check    |    Keywords:            
     Author:  David Kirkby  |    Upstream:  N/A       
   Reviewer:                |      Merged:            
Work_issues:                |  
----------------------------+-----------------------------------------------

Comment(by jhpalmieri):

 Is this ready for review?

 Given the positive review for #9041, this basically looks good to me.  On
 my mac, I get test failures also:
 {{{
 5 tests failed:
     test_asynchat test_ctypes test_distutils test_locale test_smtplib
 39 tests skipped:
     test__locale test_aepack test_al test_applesingle test_bsddb
     test_bsddb3 test_cd test_cl test_codecmaps_cn test_codecmaps_hk
     test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw test_curses
     test_dl test_epoll test_gdbm test_gl test_imageop test_imgfile
     test_largefile test_linuxaudiodev test_macos test_macostools
     test_normalization test_ossaudiodev test_pep277 test_py3kwarn
     test_scriptpackages test_smtpnet test_socketserver test_startfile
     test_sunaudiodev test_timeout test_urllib2net test_urllibnet
     test_winreg test_winsound test_zipfile64
 5 skips unexpected on darwin:
     test_macos test_applesingle test_dl test_aepack
     test_scriptpackages
 }}}
 Two comments: if I set SAGE_CHECK to "yes" and run "sage -i python...",
 then it tells me that an error occurred, but then I get
 {{{
 $ echo ?$
 0
 }}}
 I think this is a problem with how the script sage-sage is written, not
 this patch.

 Also, "occurred" is misspelled in sage-check: it's missing an "r". Please
 fix this. The use of "whilst" looks a little strange to me, since it is
 followed a few lines later with "while" (from the script sage-spkg):
 {{{
 An error occured whilst testing Python
 *************************************
 Error testing package ** python-2.6.4.p9 **
 *************************************
 sage: An error occurred while testing python-2.6.4.p9
 }}}
 But that doesn't need to be changed.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9295#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to