#8645: maxima package fails to install ECL library
-------------------------+--------------------------------------------------
Reporter: burcin | Owner: tbd
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.4.4
Component: packages | Resolution:
Keywords: maxima, ecl | Author: Nils Bruin
Upstream: N/A | Reviewer:
Merged: | Work_issues:
-------------------------+--------------------------------------------------
Changes (by drkirkby):
* status: needs_review => positive_review
Comment:
Replying to [comment:18 nbruin]:
> Replying to [comment:17 drkirkby]:
>
> > Are you sure that is correct? #9264 only makes changes to ECL, not
Maxima.
>
> Except for the "Important" section and the comment in the positive
review. Only upgrading ECL will lead to maxima not building, so no
doctests will pass. A successful merge has to include a change to maxima.
That was my point - upgrading just ECL would not have worked.
> (incidentally, on #9264 it would have helped a lot if you had also run
"make test" or "make ptest" after the successful build. One of the issues
on #8731 was that it people were unsure whether the doctest failures were
due to the ECL upgrade or the maxima upgrade. We now know it's just due to
maxima 5.21 behaving differently)
OK, point taken.
It would be good if there was a list of doc tests associated with each
package, so its possible to quickly test if changes break any tests.
Anyway, positive review.
== Note to release manager ==
This ticket, and #9264 need to be merged together. Merging #9264 without
this one will cause problems.
Dave
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8645#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
