#9336: Improve doctest coverage for sage/rings/number_field
------------------------------+---------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.5
Component: number fields | Keywords: doctest
Author: David Loeffler | Upstream: N/A
Reviewer: John Cremona | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => John Cremona
* author: => David Loeffler
Comment:
Good job! Patch applies to 4.4.4 and tests pass and docs build fine.
After this the number_fields directory scores as follows:
{{{
SCORE sage/rings/number_field//unit_group.py: 100% (15 of 15)
SCORE sage/rings/number_field//number_field_element.pyx: 81% (91 of 111)
SCORE sage/rings/number_field//totallyreal.pyx: 100% (4 of 4)
SCORE sage/rings/number_field//number_field_base.pyx: 72% (8 of 11)
SCORE sage/rings/number_field//order.py: 100% (62 of 62)
SCORE sage/rings/number_field//number_field_element_quadratic.pyx: 95% (42
of 44)
SCORE sage/rings/number_field//number_field.py: 100% (183 of 183)
SCORE sage/rings/number_field//number_field_ideal.py: 92% (72 of 78)
SCORE sage/rings/number_field//totallyreal_dsage.py: 13% (2 of 15)
SCORE sage/rings/number_field//maps.py: 100% (23 of 23)
SCORE sage/rings/number_field//number_field_rel.py: 91% (62 of 68)
SCORE sage/rings/number_field//totallyreal_data.pyx: 100% (7 of 7)
SCORE sage/rings/number_field//small_primes_of_degree_one.py: 100% (4 of
4)
SCORE sage/rings/number_field//galois_group.py: 100% (29 of 29)
SCORE sage/rings/number_field//number_field_ideal_rel.py: 78% (22 of 28)
SCORE sage/rings/number_field//totallyreal_rel.py: 60% (3 of 5)
SCORE sage/rings/number_field//morphism.py: 100% (22 of 22)
SCORE sage/rings/number_field//class_group.py: 72% (13 of 18)
SCORE sage/rings/number_field//number_field_morphisms.pyx: 100% (13 of 13)
SCORE sage/rings/number_field//totallyreal_phc.py: 100% (2 of 2)
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9336#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
