#9336: Improve doctest coverage for sage/rings/number_field
------------------------------+---------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5
Component: number fields | Keywords: doctest
Author: David Loeffler | Upstream: N/A
Reviewer: John Cremona | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by fwclarke):
* status: positive_review => needs_work
Comment:
Just one little niggle: according to the developer's guide, code like
{{{
try:
return self.list()[0]
except:
raise ValueError, "Set is empty"
}}}
(lines 91 to 94 in the patched morphism.py) should be avoided. Better
would be
{{{
try:
return self[0]
except IndexError:
raise ValueError, "Set is empty"
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9336#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
