#8680: untabify Sage again, and make it stick
------------------------------+---------------------------------------------
Reporter: jhpalmieri | Owner: jason
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.5
Component: doctest | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: David Loeffler | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by davidloeffler):
Replying to [comment:13 leif]:
> Just for the record: I've successfully applied David's patch to
4.5.alpha1 (without the optional GLPK package) and all tests passed
({{{ptestlong}}}).
>
> (I did ''not'' yet apply the patch to {{{sage-doctest}}}.)
>
If you had done so, you'd have noticed that it brings up the following
bug:
{{{
**********************************************************************
File "/storage/masiao/sage-4.5.alpha1/devel/sage-
reviewing/sage/combinat/words/suffix_trees.py", line 604:
sage: s._word_content
Expected:
doctest:492: DeprecationWarning: _word_content is deprecated, use
_letters instead
['c', 'a', 'c', 'a', 'o']
Got:
doctest:509: DeprecationWarning: _word_content is deprecated, use
_letters instead
['c', 'a', 'c', 'a', 'o']
}}}
I didn't notice this before either, since it doesn't occur if you use
{{{sage -t}}}, but it does occur if you use {{{make ptest[long]}}}, for
some reason. In any case the correct solution is clearly for the line
number to be replaced by {{{...}}}, so it doesn't break every time someone
changes the doctest script.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8680#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
