#9245: Add library of toric varieties
----------------------------------+-----------------------------------------
   Reporter:  vbraun              |       Owner:  AlexGhitza  
       Type:  enhancement         |      Status:  needs_review
   Priority:  major               |   Milestone:              
  Component:  algebraic geometry  |    Keywords:              
     Author:  Volker Braun        |    Upstream:  N/A         
   Reviewer:  Andrey Novoseltsev  |      Merged:              
Work_issues:                      |  
----------------------------------+-----------------------------------------

Comment(by novoselt):

 * I don't think that `coordinate_points=ray2point.values()` does what you
 want - the order of elements in the dictionary is unpredictable. I think
 that
 {{{
 ray2point = dict([ (i, points.index(r)) for i,r in enumerate(rays)])
 }}}
  should be replaced with
 {{{
 ray2point = [points.index(r) for r in rays]
 }}}

  * Is there any reason why coordinate names are given in constructor
 functions? It seems to me that they would look better next to the rays in
 the data block.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9245#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to