#7379: layout interact controls
---------------------------+------------------------------------------------
   Reporter:  jason        |       Owner:  jason     
       Type:  enhancement  |      Status:  needs_work
   Priority:  major        |   Milestone:  sage-4.5  
  Component:  notebook     |    Keywords:            
     Author:  Jason Grout  |    Upstream:  N/A       
   Reviewer:  M            |      Merged:            
Work_issues:               |  
---------------------------+------------------------------------------------
Changes (by timdumol):

  * status:  positive_review => needs_work
  * reviewer:  => M


Comment:

 The patch causes the followinger doctest error:

 {{{
 File "/opt/sage/local/lib/python2.6/site-
 packages/sagenb-0.8.1-py2.6.egg/sagenb/notebook/interact.py", line 2209:
     sage: @interact
     def _(n=(Integer(10),Integer(100),Integer(1)), auto_update=False):
         show(factor(x**n - Integer(1)))
 Exception raised:
     Traceback (most recent call last):
       File "/opt/sage/local/bin/ncadoctest.py", line 1231, in run_one_test
         self.run_one_example(test, example, filename, compileflags)
       File "/opt/sage/local/bin/sagedoctest.py", line 38, in
 run_one_example
         OrigDocTestRunner.run_one_example(self, test, example, filename,
 compileflags)
       File "/opt/sage/local/bin/ncadoctest.py", line 1172, in
 run_one_example
         compileflags, 1) in test.globs
       File "<doctest __main__.example_99[9]>", line 2, in <module>
         def _(n=(Integer(10),Integer(100),Integer(1)), auto_update=False):
       File "/opt/sage/local/lib/python/site-packages/sage/misc/misc.py",
 line 2666, in my_wrap
         return func(*args)
       File "/opt/sage/local/lib/python2.6/site-
 packages/sagenb-0.8.1-py2.6.egg/sagenb/notebook/interact.py", line 2523,
 in interact
         html(C.render())
       File "/opt/sage/local/lib/python2.6/site-
 packages/sagenb-0.8.1-py2.6.egg/sagenb/notebook/interact.py", line 2062,
 in render
         s = "%s%s"%(self.render_controls(), self.render_output())
       File "/opt/sage/local/lib/python2.6/site-
 packages/sagenb-0.8.1-py2.6.egg/sagenb/notebook/interact.py", line 1998,
 in render_controls
         layout = [[c.var()] for c in self.__controls]
     AttributeError: 'UpdateButton' object has no attribute 'var'
 }}}

 Marking this as "needs work."

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7379#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to