#4000: Implement QQ['x'] via Flint ZZ['x'] + denominator
--------------------------------------------------------------------------+-
Reporter: malb |
Owner: somebody
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-4.5.2
Component: basic arithmetic |
Keywords:
Author: Sebastian Pancratz, Martin Albrecht |
Upstream: N/A
Reviewer: John Cremona, Martin Albrecht, Alex Ghitza, Harald Schilly |
Merged:
Work_issues: |
--------------------------------------------------------------------------+-
Comment(by rlm):
Some minor quibbles:
1. You might want to clean up the commit messages in the patches. Right
now they don't include the ticket number, etc. If you're using queues this
is `hg qrefresh -e` when the relevant patch is at the top of the applied
part of the queue.
2. I'm not sure it's necessary to have things like
{{{
NOTES:
(S Pancratz) Extracted from polynomial_template.pxi.
}}}
since the files are all under revision control, and in fact every line has
a list of authors associated to it.
3. It might be useful to have the cimports and the imports in separate
blocks, since the cimports happen at compile time, and the imports happen
at runtime, frequently on startup.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4000#comment:72>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
