#4000: Implement QQ['x'] via Flint ZZ['x'] + denominator
--------------------------------------------------------------------------+-
Reporter: malb |
Owner: somebody
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-4.5.2
Component: basic arithmetic |
Keywords:
Author: Sebastian Pancratz, Martin Albrecht |
Upstream: N/A
Reviewer: John Cremona, Martin Albrecht, Alex Ghitza, Harald Schilly |
Merged:
Work_issues: |
--------------------------------------------------------------------------+-
Comment(by spancratz):
Hi Harald,
Thank you for looking at this again. The timings you provide are all
obtained by the new implementation. For example, multiplying to degree
3000 polynomials takes 15ms with the new implementation as you show, but
took 600ms before as explained in the description at the top of this
ticket! --- And this is the advertised improvement by a factor of 40 in a
basic arithmetic operation :)
This is because the implementation is provided alongside the old, it is
simply a drop in replacement for the old one. Using the parameter
"implementation" doesn't raise an error, but it doesn't do anything useful
either.
So far, I have only tested the patch against Sage 4.4.4 and so I can't
comment on the last problem that you mention. I will look at that soon.
As a preliminary opinion I believe that the test is a very bad one: I can
see that f(x) == f should return true. However, I do not think that f(x)
is f should return true. After all, f(g) for any other g, e.g. g = x*x,
returns a new polynomial object.
Many thanks for looking at this,
Sebastian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4000#comment:76>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
