#6456: Upgrade cvxopt in sage from 0.9 to 1.1.2
--------------------------------+-------------------------------------------
Reporter: was | Owner: mabshoff
Type: defect | Status: needs_info
Priority: major | Milestone: sage-4.5.2
Component: packages | Keywords:
Author: schilly, dimpase | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Comment(by drkirkby):
Replying to [comment:48 dimpase]:
> Replying to [comment:45 drkirkby]:
> > Are you sure its a good idea to merge the changes from #9598? IMHO, it
would be better to make these tickets separate, as:
>
> Dave, it's just the question of turning a particular interface on.
> There should be no problems --- most of all cause there is 0 exposure of
> this to any Sage code at the moment.
>
> The next step would be to have a proper test for this somewhere...
But my understanding is that there should be a test, so code like that in
#9598 can't be committed until there is a test and documentation for it -
I note that some documentation has now been added, though I'm not sure
about test code. It does not seem right to me to link to a library when
* Whether the linking on some platforms is untested.
* The is no documentation to cvxopt to show how to use this library.
* There is no test code.
(That was the situation at the time I marked it as needing work - that may
have changed now).
Note also that cvxopt does have test code, which is not executed. Since
that was not before, I'm not suggesting that should be made conditional on
getting a positive review. But given this ticket will not be merged in
4.5.2 (as only one .spkg file will be), it would seem wise to sort out
that too, and run the package's self-tests. That would mean restoring the
documentation and examples, as that is how this code gets tested.
Sorry if I appear too pedantic, but I'm just trying to ensure that what we
have works on all platforms, is tested on all platforms, and is documented
properly.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6456#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
