#6456: Upgrade cvxopt in sage from 0.9 to 1.1.2
--------------------------------+-------------------------------------------
Reporter: was | Owner: mabshoff
Type: defect | Status: needs_info
Priority: major | Milestone: sage-4.5.2
Component: packages | Keywords:
Author: schilly, dimpase | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Comment(by drkirkby):
Replying to [comment:55 dimpase]:
> Replying to [comment:40 drkirkby]:
> > I should add, {{{/usr/include/complex.h}}} is included in the first
release of Solaris 10 (released in March 2005) and also in the latest
!OpenSolaris build. There seems little point in doing what we are doing,
espeically given it is doubtful if this is legal - the header is not
released under the GPL.
>
> sun_complex.h is in the current cvxopt spkg.
> I added the sun_complex.h inclusion to 1.1.2 cause I was not able to
make it work on t2 otherwise. So I just went with the solution that is
known to work.
>
> Note that <complex.h> is included in cvxopt.h by default, albeit under
some condition, etc.
>
> If you have a better solution that works on t2, please post a patch
here, and I make
> cvxopt-1.1.2.p2.spkg that incorporates it.
> I am also willing to put back examples and docs.
>
> Dima
The current patch for Solaris does not work at all with gcc 4.5, as
there's a syntax error in the code I wrote above, which you copied.
This line is not legal C
{{{
#ifdef if defined __sun /* Need to check if that's the best one */
}}}
and gives a warning from the compiler
{{{
In file included from C/glpk.c:20:0:
C/cvxopt.h:30:11: warning: extra tokens at end of #ifdef directive
}}}
It then goes on to give an error message, as I suspect the header file
<complex.h> does not get included. I suspect gcc is interpreting this as
{{{
#ifdef if
}}}
I think we need the documentation and examples back, add an spkg-check
file, and run all the self-tests. Unfortunately, I don't have time to do
any of that now, though I can do it later today. (My wife is waiting on me
to do some things in the house!)
Note Peter's problem is new to this upgrade, and the warning looks to me
that it could cause a problem on any 64-bit system - irrespective of
whether -m64 is added as a compiler flag. In fact, I doubt Peter ever uses
-m64 in his builds on FreeBSD.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6456#comment:56>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
