#9603: Force iconv to build + install on HP-UX. Currently it is only installed
on
Solaris and Cygwin.
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: drkirkby
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: pjeremy | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by leif):
Style-wise, I would invert the test to something like:
{{{
#!sh
if [ "$UNAME" = SunOS -o "$UNAME" = CYGWIN -o "$UNAME" = HP-UX ]; then
# install spkg/run test suite, check exit code, ...
else
# print message that iconv will not be installed/tested
# because *the system's* one is/will be used (rather than
# the one shipped with Sage), exit 0
fi
}}}
(I.e., clarifying the messages a bit, too.)
Dave, you're right, I do not have access to an HP-UX system, but I don't
think that's necessary to give it a positive review.
I'll later take a look at the whole...
-Leif
P.S.: Peter is (already) listed as reviewer, should I than delete him in
case I give it positive review (and if he hasn't yet)?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9603#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
