#9603: Force iconv to build + install on HP-UX. Currently it is only installed
on
Solaris and Cygwin.
--------------------------------------------+-------------------------------
Reporter: drkirkby | Owner: drkirkby
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: Peter Jeremy, Leif Leonhardy | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by leif):
Replying to [comment:10 drkirkby]:
> Replying to [comment:8 leif]:
> > P.S.: Peter is (already) listed as reviewer, should I than delete him
in case I give it positive review (and if he hasn't yet)?
I completely missed his comment at that time, and did not notice he added
his name himself there, sorry for that. (Though most tickets only list
those as reviewers who actually gave ''positive'' review... - not a very
good practice IMO.)
> I try to write my scripts as portable as I possibly can. I've tended to
ask on [http://groups.google.com/group/comp.unix.shell/topics
comp.unix.shell] where some shell scripting wizards hang out. I've just
asked
[http://groups.google.com/group/comp.unix.shell/browse_thread/thread/4081999fef86b878#
for comment on -o vs ||]
Of course a bit funny to both require {{{bash}}} and then try to be as
portable as possible with respect to the shell (though {{{test}}} is
actually a ''program'', too), but I don't mind.
> Changing the style introduces risks that I'd rather not introduce. The
risk of introducing a bug increases the more changes one makes to the
script. I would not be very popular if I tried to implement something for
HP-UX that happens to break on some Linux system! At the moment the script
does work reliably, so I'd prefer to limit the changes that are necessary
to achieve the aim.
Hmm, my main intention was to just invert the test, because it's bad style
(and inefficient and I think more error-prone) as it is now.
Of course you can use {{{[ ... ] || [ ... ] || ...}}} as well, though this
invokes more instances of {{{test}}} if it's not a shell built-in.
> The top of spkg-install has a description of what it is doing, and a
link to the ticket which resulted in the decision to make iconv install
only on Solaris and Cygwing, so I'm not really sure there is need for
further explanation.
> If you feel there needs to be some more comments in the code, I will add
them.
I meant just the ''messages'' visible to the user.
> But I do not feel changing the style is a good idea. It introduces
unnecessary risks.
See above. Every code change of course carries some risk (cf. the garbage
in PARI's {{{spkg-install}}}), but if tickets were always reviewed
properly, such things would (or will) not happen. In my opinion cleaning
up "grown" code is important, too. (And sometimes it's even better to
rewrite things from scratch.)
-Leif
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9603#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
